Re: [PATCH v3 4/4] riscv: Convert custom spinlock/rwlock to generic qspinlock/qrwlock
From: kernel test robot
Date: Thu Mar 25 2021 - 07:16:51 EST
Hi,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on tip/locking/core]
[also build test ERROR on linux/master linus/master v5.12-rc4 next-20210325]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/guoren-kernel-org/riscv-Add-qspinlock-qrwlock/20210325-155933
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 5965a7adbd72dd9b288c0911cb73719fed1efa08
config: riscv-rv32_defconfig (attached as .config)
compiler: riscv32-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/2bf2d117ab34b007089e20e1c46eff89b5da097e
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review guoren-kernel-org/riscv-Add-qspinlock-qrwlock/20210325-155933
git checkout 2bf2d117ab34b007089e20e1c46eff89b5da097e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All errors (new ones prefixed by >>):
kernel/locking/qspinlock.c: Assembler messages:
kernel/locking/qspinlock.c:184: Error: unrecognized opcode `srliw t1,t1,16'
kernel/locking/qspinlock.c:185: Error: unrecognized opcode `slliw t1,t1,16'
>> kernel/locking/qspinlock.c:190: Error: unrecognized opcode `slliw a6,a6,16'
>> kernel/locking/qspinlock.c:191: Error: unrecognized opcode `srliw a6,a6,16'
kernel/locking/qspinlock.c:184: Error: unrecognized opcode `slliw t1,t1,16'
kernel/locking/qspinlock.c:185: Error: unrecognized opcode `srliw t1,t1,16'
kernel/locking/qspinlock.c:187: Error: unrecognized opcode `slliw t3,t3,16'
>> kernel/locking/qspinlock.c:191: Error: unrecognized opcode `srliw a6,a6,16'
vim +190 kernel/locking/qspinlock.c
69f9cae90907e0 Peter Zijlstra (Intel 2015-04-24 187)
59fb586b4a07b4 Will Deacon 2018-04-26 188 /**
59fb586b4a07b4 Will Deacon 2018-04-26 189 * clear_pending - clear the pending bit.
59fb586b4a07b4 Will Deacon 2018-04-26 @190 * @lock: Pointer to queued spinlock structure
59fb586b4a07b4 Will Deacon 2018-04-26 @191 *
59fb586b4a07b4 Will Deacon 2018-04-26 192 * *,1,* -> *,0,*
59fb586b4a07b4 Will Deacon 2018-04-26 193 */
59fb586b4a07b4 Will Deacon 2018-04-26 194 static __always_inline void clear_pending(struct qspinlock *lock)
59fb586b4a07b4 Will Deacon 2018-04-26 195 {
59fb586b4a07b4 Will Deacon 2018-04-26 196 atomic_andnot(_Q_PENDING_VAL, &lock->val);
59fb586b4a07b4 Will Deacon 2018-04-26 197 }
59fb586b4a07b4 Will Deacon 2018-04-26 198
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip