Re: [PATCH v5] audit: log nftables configuration change events once per table
From: Pablo Neira Ayuso
Date: Wed Mar 31 2021 - 16:57:31 EST
On Wed, Mar 31, 2021 at 04:53:10PM -0400, Richard Guy Briggs wrote:
> On 2021-03-31 22:22, Pablo Neira Ayuso wrote:
> > On Fri, Mar 26, 2021 at 01:38:59PM -0400, Richard Guy Briggs wrote:
> > > Reduce logging of nftables events to a level similar to iptables.
> > > Restore the table field to list the table, adding the generation.
> > >
> > > Indicate the op as the most significant operation in the event.
> >
> > There's a UAF, Florian reported. I'm attaching an incremental fix.
> >
> > nf_tables_commit_audit_collect() refers to the trans object which
> > might have been already released.
>
> Got it. Thanks Pablo. I didn't see it when running nft-test.py Where
> was it reported?
CONFIG_KASAN.
> Here I tried to stay out of the way by putting that
> call at the end of the loop but that was obviously a mistake in
> hindsight. :-)
No problem, I'll squash this incremental fix into your audit patch.