Re: [PATCH V5 08/10] x86/entry: Preserve PKRS MSR across exceptions

From: Ira Weiny
Date: Wed Mar 31 2021 - 21:16:48 EST


On Wed, Mar 31, 2021 at 12:31:56PM -0700, Dave Hansen wrote:
> On 3/31/21 12:14 PM, ira.weiny@xxxxxxxxx wrote:
> > + * To protect against exceptions having access to this memory we save the
> > + * current running value and sets the PKRS value to be used during the
> > + * exception.
>
> This series seems to have grown some "we's".

I suppose it has...

>
> The preexisting pkey code was not innocent in this regard, either. But,
> please fix this up across the series in the next submission. Literally
> removing "we" from this sentence doesn't change the meaning at all.

Sure I can audit the series for this... Waiting a day for other comments.

Thanks,
Ira