Re: [PATCH] pata_ipx4xx_cf: Fix unsigned comparison with less than zero

[Sergei Shtylyov]

On 10.04.2021 2:38, angkery wrote:
> On Fri, 9 Apr 2021 20:02:56 +0300
> Sergei Shtylyov <sergei.shtylyov@xxxxxxxxx> wrote:
>
> > On 4/9/21 7:49 PM, Sergei Shtylyov wrote:
> >
> > > > From: Junlin Yang <yangjunlin@xxxxxxxxxx>
> > > >
> > > > The return from the call to platform_get_irq() is int, it can be
> > > > a negative error code, however this is being assigned to an
> > > > unsigned int variable 'irq', so making 'irq' an int, and change
> > > > the position to keep the code format.
> > > >
> > > > ./drivers/ata/pata_ixp4xx_cf.c:168:5-8:
> > > > WARNING: Unsigned expression compared with zero: irq > 0
> > >
> > >     I'd understand < 0... but > 0? What tool warned about this issue?
> > >    
> > > > yes, by coccicheck, i will update commits information.

   Thanks!
   Yet, looking at your subject, the above should read irq < 0, not > 0.

> > > > Signed-off-by: Junlin Yang <yangjunlin@xxxxxxxxxx>