Re: [PATCH v1] pata_ipx4xx_cf: Fix unsigned comparison with less than zero

[Sergei Shtylyov]

On 10.04.2021 2:42, angkery wrote:

> From: Junlin Yang <yangjunlin@xxxxxxxxxx>
>
> The return from the call to platform_get_irq() is int, it can be
> a negative error code, however this is being assigned to an unsigned
> int variable 'irq', so making 'irq' an int, and change the position to
> keep the code format.
>
> Fixes coccicheck warnings:
> ./drivers/ata/pata_ixp4xx_cf.c:168:5-8:
> WARNING: Unsigned expression compared with zero: irq > 0
>
> Signed-off-by: Junlin Yang <yangjunlin@xxxxxxxxxx>
> ---
> changes in v1:
> update the commit information.

   Not seeing what's updated, and anwyways it should read irq < 0, else it 
doesn't make sense...

[...]

MBR, Sergei