Re: [PATCH 1/5] scsi: BusLogic: Fix missing `pr_cont' use
From: Maciej W. Rozycki
Date: Fri Apr 16 2021 - 10:28:58 EST
On Fri, 16 Apr 2021, Joe Perches wrote:
> > I'm not sure if that complex message
> > routing via `blogic_msg' is worth having even, rather than calling
> > `printk' or suitable variants directly.
>
> It's to allow the message content to be added to the internal
> &adapter->msgbuf[adapter->msgbuflen]
> with strcpy for later use with blogic_show_info()/seq_write.
I know, but it's not clear to me if it's worth it (a potential buffer
overrun there too, BTW).
Maciej