Re: [PATCH 1/5] scsi: BusLogic: Fix missing `pr_cont' use
From: Joe Perches
Date: Fri Apr 16 2021 - 11:17:04 EST
On Fri, 2021-04-16 at 16:28 +0200, Maciej W. Rozycki wrote:
> On Fri, 16 Apr 2021, Joe Perches wrote:
> > > I'm not sure if that complex message
> > > routing via `blogic_msg' is worth having even, rather than calling
> > > `printk' or suitable variants directly.
> > It's to allow the message content to be added to the internal
> > &adapter->msgbuf[adapter->msgbuflen]
> > with strcpy for later use with blogic_show_info()/seq_write.
> I know, but it's not clear to me if it's worth it (a potential buffer
> overrun there too, BTW).
It's seq_ output so it's nominally an ABI.
But then again, I don't use this at all so I don't care much either.
It's also odd/bad form that one output KERN_<level> does not match
its blogic_<level> (blogic_info is emitted at KERN_NOTICE)