Re: [PATCH -next] reiserfs: Remove unneed check in reiserfs_write_full_page()

[Jan Kara]

On Sun 23-05-21 17:02:58, YueHaibing wrote:
> Condition !A || A && B is equivalent to !A || B.
> 
> Generated by: scripts/coccinelle/misc/excluded_middle.cocci
> 
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>

Fair enough. Thanks for the patch. Added to my tree.

								Honza

> ---
>  fs/reiserfs/inode.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/fs/reiserfs/inode.c b/fs/reiserfs/inode.c
> index 780bb90c1804..f49b72ccac4c 100644
> --- a/fs/reiserfs/inode.c
> +++ b/fs/reiserfs/inode.c
> @@ -2584,9 +2584,7 @@ static int reiserfs_write_full_page(struct page *page,
>  			clear_buffer_dirty(bh);
>  			set_buffer_uptodate(bh);
>  		} else if ((checked || buffer_dirty(bh)) &&
> -		           (!buffer_mapped(bh) || (buffer_mapped(bh)
> -						       && bh->b_blocknr ==
> -						       0))) {
> +			   (!buffer_mapped(bh) || bh->b_blocknr == 0)) {
>  			/*
>  			 * not mapped yet, or it points to a direct item, search
>  			 * the btree for the mapping info, and log any direct
> -- 
> 2.20.1
> 
-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR