Re: [PATCH v1] kbuild: Disable compile testing if HAVE_LEGACY_CLK enabled
From: Randy Dunlap
Date: Tue May 25 2021 - 20:40:09 EST
On 5/25/21 2:29 PM, Dmitry Osipenko wrote:
> 25.05.2021 15:19, Geert Uytterhoeven пишет:
> ...
>>>> There 3 possible solutions:
>>>>
>>>> 1. Factor out COMMON_CLK from HAVE_LEGACY_CLK, if this is possible
>>>> 2. Build stubs universally, maybe using weak functions.
>>>
>>> I vote for this one - global stubs.
>>
>> Yep.
>>
>>> Or for a new one:
>>> 4. Disable COMPILE_TEST for specific platforms (mentioned in commit
>>> msg). Eventually could be like:
>>> config RALINK
>>> depends !COMPILE_TEST || (COMPILE_TEST && COMMON_CLK)
>>
>> That's a neat idea!
>>
>> Of course there's a fifth option:
>>
>> 5. Convert legacy platforms to COMMON_CLK.
>>
>> Which is already happening for ARM EP93XX.
>
> I'll try to take a closer look at alternative options, thank you for
> yours input.
Hi,
If you are messing around with HAVE_LEGACY_CLK and COMMON_CLK
and don't mind, please have a look at this report from
'kernel test robot':
https://lore.kernel.org/lkml/202103162301.oomY9NwI-lkp@xxxxxxxxx/
Maybe this one is more MIPS-specific. I dunno.
I tried to come up with a patch for it and failed.
I will be happy to built-test any patches that you come up with.
Maybe I have just looked at this too long...
thanks.
--
~Randy