Re: [PATCH v1] kbuild: Disable compile testing if HAVE_LEGACY_CLK enabled

From: Arnd Bergmann
Date: Fri May 28 2021 - 05:29:28 EST


On Wed, May 26, 2021 at 2:39 AM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:
> On 5/25/21 2:29 PM, Dmitry Osipenko wrote:
> > 25.05.2021 15:19, Geert Uytterhoeven пишет:
> If you are messing around with HAVE_LEGACY_CLK and COMMON_CLK
> and don't mind, please have a look at this report from
> 'kernel test robot':
> https://lore.kernel.org/lkml/202103162301.oomY9NwI-lkp@xxxxxxxxx/
>
>
> Maybe this one is more MIPS-specific. I dunno.
> I tried to come up with a patch for it and failed.
>
> I will be happy to built-test any patches that you come up with.
>
> Maybe I have just looked at this too long...

This is exactly the case that Dmitry is trying to solve. The problem
is that bcm63xx
and lantiq set CONFIG_HAVE_LEGACY_CLK but lack the clk_set_parent()
and clk_get_parent() functions. We could add the same stubs for these
two that we have for the other legacy clk implementations, or rework the
handling of legacy clocks completely.

Arnd