Re: [irqchip: irq/irqchip-next] powerpc: Drop dependency between asm/irq.h and linux/irqdomain.h

From: kernel test robot
Date: Sun Jun 06 2021 - 11:03:20 EST

Hi irqchip-bot,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on powerpc/next]
[also build test ERROR on linux/master linus/master v5.13-rc4 next-20210604]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/irqchip-bot-for-Marc-Zyngier/powerpc-Drop-dependency-between-asm-irq-h-and-linux-irqdomain-h/20210606-205106
base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-sbc8548_defconfig (attached as .config)
compiler: powerpc-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/72415db4cc9ec9987380123553c3222a3568f37f
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review irqchip-bot-for-Marc-Zyngier/powerpc-Drop-dependency-between-asm-irq-h-and-linux-irqdomain-h/20210606-205106
git checkout 72415db4cc9ec9987380123553c3222a3568f37f
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

arch/powerpc/sysdev/fsl_mpic_err.c: In function 'fsl_error_int_handler':
>> arch/powerpc/sysdev/fsl_mpic_err.c:111:17: error: implicit declaration of function 'irq_linear_revmap' [-Werror=implicit-function-declaration]
111 | cascade_irq = irq_linear_revmap(mpic->irqhost,
| ^~~~~~~~~~~~~~~~~
arch/powerpc/sysdev/fsl_mpic_err.c: In function 'mpic_err_int_init':
>> arch/powerpc/sysdev/fsl_mpic_err.c:131:9: error: implicit declaration of function 'irq_create_mapping' [-Werror=implicit-function-declaration]
131 | virq = irq_create_mapping(mpic->irqhost, irqnum);
| ^~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors


vim +/irq_linear_revmap +111 arch/powerpc/sysdev/fsl_mpic_err.c

0a4081641d722d Varun Sethi 2012-08-08 95
0a4081641d722d Varun Sethi 2012-08-08 96 static irqreturn_t fsl_error_int_handler(int irq, void *data)
0a4081641d722d Varun Sethi 2012-08-08 97 {
0a4081641d722d Varun Sethi 2012-08-08 98 struct mpic *mpic = (struct mpic *) data;
0a4081641d722d Varun Sethi 2012-08-08 99 u32 eisr, eimr;
0a4081641d722d Varun Sethi 2012-08-08 100 int errint;
0a4081641d722d Varun Sethi 2012-08-08 101 unsigned int cascade_irq;
0a4081641d722d Varun Sethi 2012-08-08 102
0a4081641d722d Varun Sethi 2012-08-08 103 eisr = mpic_fsl_err_read(mpic->err_regs, MPIC_ERR_INT_EISR);
0a4081641d722d Varun Sethi 2012-08-08 104 eimr = mpic_fsl_err_read(mpic->err_regs, MPIC_ERR_INT_EIMR);
0a4081641d722d Varun Sethi 2012-08-08 105
0a4081641d722d Varun Sethi 2012-08-08 106 if (!(eisr & ~eimr))
0a4081641d722d Varun Sethi 2012-08-08 107 return IRQ_NONE;
0a4081641d722d Varun Sethi 2012-08-08 108
0a4081641d722d Varun Sethi 2012-08-08 109 while (eisr) {
0a4081641d722d Varun Sethi 2012-08-08 110 errint = __builtin_clz(eisr);
0a4081641d722d Varun Sethi 2012-08-08 @111 cascade_irq = irq_linear_revmap(mpic->irqhost,
0a4081641d722d Varun Sethi 2012-08-08 112 mpic->err_int_vecs[errint]);
ef24ba7091517d Michael Ellerman 2016-09-06 113 WARN_ON(!cascade_irq);
ef24ba7091517d Michael Ellerman 2016-09-06 114 if (cascade_irq) {
0a4081641d722d Varun Sethi 2012-08-08 115 generic_handle_irq(cascade_irq);
0a4081641d722d Varun Sethi 2012-08-08 116 } else {
0a4081641d722d Varun Sethi 2012-08-08 117 eimr |= 1 << (31 - errint);
0a4081641d722d Varun Sethi 2012-08-08 118 mpic_fsl_err_write(mpic->err_regs, eimr);
0a4081641d722d Varun Sethi 2012-08-08 119 }
0a4081641d722d Varun Sethi 2012-08-08 120 eisr &= ~(1 << (31 - errint));
0a4081641d722d Varun Sethi 2012-08-08 121 }
0a4081641d722d Varun Sethi 2012-08-08 122
0a4081641d722d Varun Sethi 2012-08-08 123 return IRQ_HANDLED;
0a4081641d722d Varun Sethi 2012-08-08 124 }
0a4081641d722d Varun Sethi 2012-08-08 125
0a4081641d722d Varun Sethi 2012-08-08 126 void mpic_err_int_init(struct mpic *mpic, irq_hw_number_t irqnum)
0a4081641d722d Varun Sethi 2012-08-08 127 {
0a4081641d722d Varun Sethi 2012-08-08 128 unsigned int virq;
0a4081641d722d Varun Sethi 2012-08-08 129 int ret;
0a4081641d722d Varun Sethi 2012-08-08 130
0a4081641d722d Varun Sethi 2012-08-08 @131 virq = irq_create_mapping(mpic->irqhost, irqnum);

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip