Re: [irqchip: irq/irqchip-next] irqdomain: Kill irq_domain_add_legacy_isa
From: kernel test robot
Date: Sun Jun 06 2021 - 11:07:26 EST
Hi irqchip-bot,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on tip/irq/core]
[also build test WARNING on linux/master linus/master v5.13-rc4 next-20210604]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/irqchip-bot-for-Marc-Zyngier/irqdomain-Kill-irq_domain_add_legacy_isa/20210606-204659
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 006ae1970a8cde1d3e92da69b324d12880133a13
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/7d6d9b0177b4ae53ccae4fb2c5cd387460def6ac
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review irqchip-bot-for-Marc-Zyngier/irqdomain-Kill-irq_domain_add_legacy_isa/20210606-204659
git checkout 7d6d9b0177b4ae53ccae4fb2c5cd387460def6ac
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All warnings (new ones prefixed by >>):
arch/powerpc/sysdev/i8259.c: In function 'i8259_init':
arch/powerpc/sysdev/i8259.c:263:15: error: implicit declaration of function 'irq_domain_add_legacy_isa'; did you mean 'irq_domain_add_legacy'? [-Werror=implicit-function-declaration]
263 | i8259_host = irq_domain_add_legacy_isa(node, &i8259_host_ops, NULL);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
| irq_domain_add_legacy
>> arch/powerpc/sysdev/i8259.c:263:13: warning: assignment to 'struct irq_domain *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
263 | i8259_host = irq_domain_add_legacy_isa(node, &i8259_host_ops, NULL);
| ^
cc1: some warnings being treated as errors
vim +263 arch/powerpc/sysdev/i8259.c
f4d4c354bca182 arch/powerpc/sysdev/i8259.c Benjamin Herrenschmidt 2006-10-25 215
40681b95a4ef79 arch/powerpc/sysdev/i8259.c Michael Ellerman 2006-08-02 216 /**
0ebfff1491ef85 arch/powerpc/sysdev/i8259.c Benjamin Herrenschmidt 2006-07-03 217 * i8259_init - Initialize the legacy controller
0ebfff1491ef85 arch/powerpc/sysdev/i8259.c Benjamin Herrenschmidt 2006-07-03 218 * @node: device node of the legacy PIC (can be NULL, but then, it will match
0ebfff1491ef85 arch/powerpc/sysdev/i8259.c Benjamin Herrenschmidt 2006-07-03 219 * all interrupts, so beware)
0ebfff1491ef85 arch/powerpc/sysdev/i8259.c Benjamin Herrenschmidt 2006-07-03 220 * @intack_addr: PCI interrupt acknowledge (real) address which will return
^1da177e4c3f41 arch/ppc/syslib/i8259.c Linus Torvalds 2005-04-16 221 * the active irq from the 8259
^1da177e4c3f41 arch/ppc/syslib/i8259.c Linus Torvalds 2005-04-16 222 */
0ebfff1491ef85 arch/powerpc/sysdev/i8259.c Benjamin Herrenschmidt 2006-07-03 223 void i8259_init(struct device_node *node, unsigned long intack_addr)
^1da177e4c3f41 arch/ppc/syslib/i8259.c Linus Torvalds 2005-04-16 224 {
^1da177e4c3f41 arch/ppc/syslib/i8259.c Linus Torvalds 2005-04-16 225 unsigned long flags;
^1da177e4c3f41 arch/ppc/syslib/i8259.c Linus Torvalds 2005-04-16 226
0ebfff1491ef85 arch/powerpc/sysdev/i8259.c Benjamin Herrenschmidt 2006-07-03 227 /* initialize the controller */
47e3c9046bc884 arch/powerpc/sysdev/i8259.c Thomas Gleixner 2010-02-18 228 raw_spin_lock_irqsave(&i8259_lock, flags);
0ebfff1491ef85 arch/powerpc/sysdev/i8259.c Benjamin Herrenschmidt 2006-07-03 229
0ebfff1491ef85 arch/powerpc/sysdev/i8259.c Benjamin Herrenschmidt 2006-07-03 230 /* Mask all first */
0ebfff1491ef85 arch/powerpc/sysdev/i8259.c Benjamin Herrenschmidt 2006-07-03 231 outb(0xff, 0xA1);
0ebfff1491ef85 arch/powerpc/sysdev/i8259.c Benjamin Herrenschmidt 2006-07-03 232 outb(0xff, 0x21);
f9bd170a87948a arch/powerpc/sysdev/i8259.c Paul Mackerras 2005-10-26 233
^1da177e4c3f41 arch/ppc/syslib/i8259.c Linus Torvalds 2005-04-16 234 /* init master interrupt controller */
^1da177e4c3f41 arch/ppc/syslib/i8259.c Linus Torvalds 2005-04-16 235 outb(0x11, 0x20); /* Start init sequence */
^1da177e4c3f41 arch/ppc/syslib/i8259.c Linus Torvalds 2005-04-16 236 outb(0x00, 0x21); /* Vector base */
446957ba512714 arch/powerpc/sysdev/i8259.c Adam Buchbinder 2016-02-24 237 outb(0x04, 0x21); /* edge triggered, Cascade (slave) on IRQ2 */
^1da177e4c3f41 arch/ppc/syslib/i8259.c Linus Torvalds 2005-04-16 238 outb(0x01, 0x21); /* Select 8086 mode */
^1da177e4c3f41 arch/ppc/syslib/i8259.c Linus Torvalds 2005-04-16 239
^1da177e4c3f41 arch/ppc/syslib/i8259.c Linus Torvalds 2005-04-16 240 /* init slave interrupt controller */
^1da177e4c3f41 arch/ppc/syslib/i8259.c Linus Torvalds 2005-04-16 241 outb(0x11, 0xA0); /* Start init sequence */
^1da177e4c3f41 arch/ppc/syslib/i8259.c Linus Torvalds 2005-04-16 242 outb(0x08, 0xA1); /* Vector base */
^1da177e4c3f41 arch/ppc/syslib/i8259.c Linus Torvalds 2005-04-16 243 outb(0x02, 0xA1); /* edge triggered, Cascade (slave) on IRQ2 */
^1da177e4c3f41 arch/ppc/syslib/i8259.c Linus Torvalds 2005-04-16 244 outb(0x01, 0xA1); /* Select 8086 mode */
^1da177e4c3f41 arch/ppc/syslib/i8259.c Linus Torvalds 2005-04-16 245
0ebfff1491ef85 arch/powerpc/sysdev/i8259.c Benjamin Herrenschmidt 2006-07-03 246 /* That thing is slow */
0ebfff1491ef85 arch/powerpc/sysdev/i8259.c Benjamin Herrenschmidt 2006-07-03 247 udelay(100);
0ebfff1491ef85 arch/powerpc/sysdev/i8259.c Benjamin Herrenschmidt 2006-07-03 248
^1da177e4c3f41 arch/ppc/syslib/i8259.c Linus Torvalds 2005-04-16 249 /* always read ISR */
^1da177e4c3f41 arch/ppc/syslib/i8259.c Linus Torvalds 2005-04-16 250 outb(0x0B, 0x20);
^1da177e4c3f41 arch/ppc/syslib/i8259.c Linus Torvalds 2005-04-16 251 outb(0x0B, 0xA0);
^1da177e4c3f41 arch/ppc/syslib/i8259.c Linus Torvalds 2005-04-16 252
0ebfff1491ef85 arch/powerpc/sysdev/i8259.c Benjamin Herrenschmidt 2006-07-03 253 /* Unmask the internal cascade */
0ebfff1491ef85 arch/powerpc/sysdev/i8259.c Benjamin Herrenschmidt 2006-07-03 254 cached_21 &= ~(1 << 2);
0ebfff1491ef85 arch/powerpc/sysdev/i8259.c Benjamin Herrenschmidt 2006-07-03 255
0ebfff1491ef85 arch/powerpc/sysdev/i8259.c Benjamin Herrenschmidt 2006-07-03 256 /* Set interrupt masks */
^1da177e4c3f41 arch/ppc/syslib/i8259.c Linus Torvalds 2005-04-16 257 outb(cached_A1, 0xA1);
^1da177e4c3f41 arch/ppc/syslib/i8259.c Linus Torvalds 2005-04-16 258 outb(cached_21, 0x21);
^1da177e4c3f41 arch/ppc/syslib/i8259.c Linus Torvalds 2005-04-16 259
47e3c9046bc884 arch/powerpc/sysdev/i8259.c Thomas Gleixner 2010-02-18 260 raw_spin_unlock_irqrestore(&i8259_lock, flags);
^1da177e4c3f41 arch/ppc/syslib/i8259.c Linus Torvalds 2005-04-16 261
0ebfff1491ef85 arch/powerpc/sysdev/i8259.c Benjamin Herrenschmidt 2006-07-03 262 /* create a legacy host */
1bc04f2cf8c2a1 arch/powerpc/sysdev/i8259.c Grant Likely 2012-02-14 @263 i8259_host = irq_domain_add_legacy_isa(node, &i8259_host_ops, NULL);
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx
Attachment:
.config.gz
Description: application/gzip