Re: [irqchip: irq/irqchip-next] irqdomain: Kill irq_domain_add_legacy_isa

[Marc Zyngier]

On 2021-06-06 16:06, kernel test robot wrote:
> Hi irqchip-bot,
>
> Thank you for the patch! Perhaps something to improve:
>
> [auto build test WARNING on tip/irq/core]
> [also build test WARNING on linux/master linus/master v5.13-rc4 
> next-20210604]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url:
> https://github.com/0day-ci/linux/commits/irqchip-bot-for-Marc-Zyngier/irqdomain-Kill-irq_domain_add_legacy_isa/20210606-204659
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
> 006ae1970a8cde1d3e92da69b324d12880133a13
> config: powerpc-allyesconfig (attached as .config)
> compiler: powerpc64-linux-gcc (GCC) 9.3.0
> reproduce (this is a W=1 build):
>         wget
> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
> -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         #
> https://github.com/0day-ci/linux/commit/7d6d9b0177b4ae53ccae4fb2c5cd387460def6ac
>         git remote add linux-review https://github.com/0day-ci/linux
>         git fetch --no-tags linux-review
> irqchip-bot-for-Marc-Zyngier/irqdomain-Kill-irq_domain_add_legacy_isa/20210606-204659
>         git checkout 7d6d9b0177b4ae53ccae4fb2c5cd387460def6ac
>         # save the attached .config to linux build tree
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross
> ARCH=powerpc
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
>
> All warnings (new ones prefixed by >>):
>
>    arch/powerpc/sysdev/i8259.c: In function 'i8259_init':
>    arch/powerpc/sysdev/i8259.c:263:15: error: implicit declaration of
> function 'irq_domain_add_legacy_isa'; did you mean
> 'irq_domain_add_legacy'? [-Werror=implicit-function-declaration]
>      263 |  i8259_host = irq_domain_add_legacy_isa(node, 
> &i8259_host_ops, NULL);
>          |               ^~~~~~~~~~~~~~~~~~~~~~~~~
>          |               irq_domain_add_legacy
> > > arch/powerpc/sysdev/i8259.c:263:13: warning: assignment to 'struct 
> > > irq_domain *' from 'int' makes pointer from integer without a cast 
> > > [-Wint-conversion]
>      263 |  i8259_host = irq_domain_add_legacy_isa(node, 
> &i8259_host_ops, NULL);
>          |             ^
>    cc1: some warnings being treated as errors

This makes zero sense. At the point where this patch is applied in
the series, all instances of irq_domain_add_legacy_isa() have been
removed, except for one in the Chinese translation of the documentation:

<quote>
maz@hot-poop:~/arm-platforms$ git checkout 
bf541b2ef87c162c8129333c55d2357bab122d8e
HEAD is now at bf541b2ef87c irqdomain: Kill irq_domain_add_legacy_isa
maz@hot-poop:~/arm-platforms$ git grep irq_domain_add_legacy_isa
Documentation/translations/zh_CN/core-api/irq/irq-domain.rst:   
irq_domain_add_legacy_isa()
</quote>

Are you applying the patches out of order, by any chance?

Thanks,

        M.
--
Jazz is not dead. It just smells funny...