Re: [PATCH] drm/sun4i: de3: Be explicit about supported modifiers

From: Daniel Stone
Date: Mon Jun 07 2021 - 04:37:03 EST


On Sat, 5 Jun 2021 at 08:36, Jernej Skrabec <jernej.skrabec@xxxxxxxxx> wrote:
> Currently only linear formats are supported in sun4i-drm driver, but
> SoCs like H6 supports AFBC variant of some of them in multiple cores
> (GPU, VPU, DE3). Panfrost already implements AFBC compression and is
> sometimes confused what should be default choice (linear, AFBC) if DRM
> driver is not explicit about modifier support (MiniMyth2 distro with
> MythTV app).
>
> After some discussion with Daniel Stone on #panfrost IRC, it was decided
> to make modifiers in sun4i-drm explicit, to avoid any kind of guessing,
> not just in panfrost, but everywhere. In fact, long term idea is to make
> modifier parameter in drm_universal_plane_init() mandatory (non NULL).

Thanks Piotr & Jernej!

Acked-by: Daniel Stone <daniels@xxxxxxxxxxxxx>

Cheers,
Daniel