Re: [PATCH] drm/sun4i: de3: Be explicit about supported modifiers
From: Maxime Ripard
Date: Mon Jun 07 2021 - 04:44:14 EST
On Sat, Jun 05, 2021 at 09:35:34AM +0200, Jernej Skrabec wrote:
> From: Piotr Oniszczuk <piotr.oniszczuk@xxxxxxxxx>
>
> Currently only linear formats are supported in sun4i-drm driver, but
> SoCs like H6 supports AFBC variant of some of them in multiple cores
> (GPU, VPU, DE3). Panfrost already implements AFBC compression and is
> sometimes confused what should be default choice (linear, AFBC) if DRM
> driver is not explicit about modifier support (MiniMyth2 distro with
> MythTV app).
>
> After some discussion with Daniel Stone on #panfrost IRC, it was decided
> to make modifiers in sun4i-drm explicit, to avoid any kind of guessing,
> not just in panfrost, but everywhere. In fact, long term idea is to make
> modifier parameter in drm_universal_plane_init() mandatory (non NULL).
>
> Signed-off-by: Piotr Oniszczuk <piotr.oniszczuk@xxxxxxxxx>
> Signed-off-by: Jernej Skrabec <jernej.skrabec@xxxxxxxxx>
Applied, thanks
Maxime
Attachment:
signature.asc
Description: PGP signature