Re: [PATCH net 1/2] ptp: idt82p33: optimize idt82p33_adjtime

From: Richard Cochran
Date: Thu Jun 24 2021 - 12:14:12 EST


On Thu, Jun 24, 2021 at 02:38:46PM +0000, Min Li wrote:
> For linuxptp/ptp4l, we can use step_window to adapt to the slow adjtime.
>
> I have tested this change with ptp4l for by setting step_window to 48 (assuming 16 packets per second)
> for both 8265.2/8275.1 and they performed well.

Yes, but that is a "magic" configuration that happens to work.

Don't you want your driver to work out of the box with every user
space program?

Thanks,
Richard