Re: [PATCH v4 2/2] MIPS: Loongson64: Add pm block node for Loongson-2K1000

[Sergei Shtylyov]

Hello!

On 6/28/21 6:13 PM, Qing Zhang wrote:

> The module is now supported, enable it.
> 
> Signed-off-by: Qing Zhang <zhangqing@xxxxxxxxxxx>
> ---
> 
> v3-v4:
> No change
> 
> Signed-off-by: Qing Zhang <zhangqing@xxxxxxxxxxx>
> ---
>  arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
> index 569e814def83..e31176ac0ac2 100644
> --- a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
> +++ b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
> @@ -101,6 +101,15 @@ uart0: serial@1fe00000 {
>  			no-loopback-test;
>  		};
>  
> +		pm: power-controller {
> +			device_type = "power management";
> +			compatible = "loongson, reset-controller";

   No spaces allowed here, AFAIK.

> +			reg = <0 0x1fe0700c 0 0x8>,
> +				<0 0x1fe07014 0 0x8>,
> +				<0 0x1fe07030 0 0x8>;

   Better keep those aligned...

> +			reg-names = "pm1_sts", "pm1_cnt", "rst_cnt";
> +		};
> +
[...]

MBR, Sergei