RE: [PATCH 1/2] clk: lmk04832: Depend on SPI

From: Liam Beguin
Date: Tue Jun 29 2021 - 11:01:23 EST




> -----Original Message-----
> From: Stephen Boyd <sboyd@xxxxxxxxxx>
> Sent: June 29, 2021 2:08 AM
> To: Michael Turquette <mturquette@xxxxxxxxxxxx>; Stephen Boyd
> <sboyd@xxxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-clk@xxxxxxxxxxxxxxx; kernel test
> robot <lkp@xxxxxxxxx>; Liam Beguin <lvb@xxxxxxxxxx>
> Subject: [PATCH 1/2] clk: lmk04832: Depend on SPI
>
> This driver depends on SPI. Otherwise compilation fails
>
> clk-lmk04832.c:(.text+0x1668): undefined reference to `spi_get_device_id'
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Cc: Liam Beguin <lvb@xxxxxxxxxx>
> Fixes: 3bc61cfd6f4a ("clk: add support for the lmk04832")
> Signed-off-by: Stephen Boyd <sboyd@xxxxxxxxxx>

Reviewed-by: Liam Beguin <lvb@xxxxxxxxxx>

> ---
> drivers/clk/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> index ccf77849bdbd..d49cf3ae52aa 100644
> --- a/drivers/clk/Kconfig
> +++ b/drivers/clk/Kconfig
> @@ -57,6 +57,7 @@ config CLK_HSDK
>
> config LMK04832
> tristate "Ti LMK04832 JESD204B Compliant Clock Jitter Cleaner"
> + depends on SPI
> select REGMAP_SPI
> help
> Say yes here to build support for Texas Instruments' LMK04832
> Ultra
> --
> https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/
> https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git