RE: [PATCH 2/2] clk: lmk04832: Use of match table

[Liam Beguin]

> -----Original Message-----
> From: Stephen Boyd <sboyd@xxxxxxxxxx>
> Sent: June 29, 2021 2:08 AM
> To: Michael Turquette <mturquette@xxxxxxxxxxxx>; Stephen Boyd
> <sboyd@xxxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-clk@xxxxxxxxxxxxxxx; kernel test
> robot <lkp@xxxxxxxxx>; Liam Beguin <lvb@xxxxxxxxxx>
> Subject: [PATCH 2/2] clk: lmk04832: Use of match table
> 
> Presumably we want to use this match table so add a module device table
> and set the driver match pointer appropriately.
> 
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Cc: Liam Beguin <lvb@xxxxxxxxxx>
> Fixes: 3bc61cfd6f4a ("clk: add support for the lmk04832")
> Signed-off-by: Stephen Boyd <sboyd@xxxxxxxxxx>

Reviewed-by: Liam Beguin <lvb@xxxxxxxxxx>

> ---
>  drivers/clk/clk-lmk04832.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/clk-lmk04832.c b/drivers/clk/clk-lmk04832.c
> index 0cd76e626c3d..c1095e733220 100644
> --- a/drivers/clk/clk-lmk04832.c
> +++ b/drivers/clk/clk-lmk04832.c
> @@ -1573,18 +1573,20 @@ static int lmk04832_remove(struct spi_device
> *spi)
>  }
>  static const struct spi_device_id lmk04832_id[] = {
>  	{ "lmk04832", LMK04832 },
> -	{},
> +	{}
>  };
>  MODULE_DEVICE_TABLE(spi, lmk04832_id);
> 
>  static const struct of_device_id lmk04832_of_id[] = {
>  	{ .compatible = "ti,lmk04832" },
> -	{},
> +	{}
>  };
> +MODULE_DEVICE_TABLE(of, lmk04832_of_id);
> 
>  static struct spi_driver lmk04832_driver = {
>  	.driver = {
>  		.name	= "lmk04832",
> +		.of_match_table = lmk04832_of_id,
>  	},
>  	.probe		= lmk04832_probe,
>  	.remove		= lmk04832_remove,
> --
> https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/
> https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git