Re: [PATCH] regulator: rt5033: Use linear ranges to map all voltage selection

From: ChiYuan Huang
Date: Tue Jul 06 2021 - 02:33:19 EST


Mark Brown <broonie@xxxxxxxxxx> 於 2021年7月6日 週二 上午12:53寫道:
>
> On Fri, Jul 02, 2021 at 11:47:50PM +0800, ChiYuan Huang wrote:
> > ChiYuan Huang <u0084500@xxxxxxxxx> 於 2021年7月1日 週四 下午1:53寫道:
> > > Axel Lin <axel.lin@xxxxxxxxxx> 於 2021年7月1日 週四 下午12:41寫道:
>
> > > From the regulator register in probe, it will get the current voltage
> > > from the IC.
> > > If the vout sel is not is over N_VOLTAGES, it will return the error number.
>
> > > But as I think it's the side effect to change the vout step num.
> > > To use the linear range is just to guarantee all vout sel range are included.
>
> > > That's my initial thoughts.
>
> > Like as you said, the first revision is from 2014.
> > It is almost EOL for this product.
> > To fix this seems redundant.
>
> Even if something is old it's still posible that people can use it, and
> if someone's done the work to fix it then why not?

Got it, I'll send the v2 patch to fix it.
Thanks.