Re: [PATCH] bus: Make remove callback return void
From: Samuel Iglesias Gonsálvez
Date: Tue Jul 06 2021 - 08:51:15 EST
On Tue, 2021-07-06 at 14:41 +0300, Heikki Krogerus wrote:
> On Tue, Jul 06, 2021 at 11:50:37AM +0200, Uwe Kleine-König wrote:
> > The driver core ignores the return value of this callback because
> > there
> > is only little it can do when a device disappears.
> >
> > This is the final bit of a long lasting cleanup quest where several
> > buses were converted to also return void from their remove callback.
> > Additionally some resource leaks were fixed that were caused by
> > drivers
> > returning an error code in the expectation that the driver won't go
> > away.
> >
> > With struct bus_type::remove returning void it's prevented that newly
> > implemented buses return an ignored error code and so don't
> > anticipate
> > wrong expectations for driver authors.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
>
For ipack changes:
Acked-by: Samuel Iglesias Gonsálvez <siglesias@xxxxxxxxxx>
Thanks,
Sam
Attachment:
signature.asc
Description: This is a digitally signed message part