Re: [PATCH] bus: Make remove callback return void

From: Tom Rix
Date: Tue Jul 06 2021 - 10:43:15 EST

On 7/6/21 2:50 AM, Uwe Kleine-König wrote:
The driver core ignores the return value of this callback because there
is only little it can do when a device disappears.

This is the final bit of a long lasting cleanup quest where several
buses were converted to also return void from their remove callback.
Additionally some resource leaks were fixed that were caused by drivers
returning an error code in the expectation that the driver won't go

With struct bus_type::remove returning void it's prevented that newly
implemented buses return an ignored error code and so don't anticipate
wrong expectations for driver authors.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

this patch depends on "PCI: endpoint: Make struct pci_epf_driver::remove
return void" that is not yet applied, see

I tested it using allmodconfig on amd64 and arm, but I wouldn't be
surprised if I still missed to convert a driver. So it would be great to
get this into next early after the merge window closes.

I send this mail to all people that emits for this
patch. I wonder how many recipents will refuse this mail because of the
long Cc: list :-)

Best regards

drivers/fpga/dfl.c | 4 +---
Reviewed-by: Tom Rix <trix@xxxxxxxxxx>