Re: [PATCH v1 2/3] mfd: tps65086: Make interrupt line optional
From: Rob Herring
Date: Wed Jul 14 2021 - 16:38:49 EST
On Tue, Jul 13, 2021 at 10:18:01AM +0100, Lee Jones wrote:
> On Sat, 26 Jun 2021, Emil Renner Berthing wrote:
>
> > The BeagleV Starlight v0.9 board[1] doesn't have the IRQB line routed to
> > the SoC, but it is still useful to be able to reach the PMIC over I2C
>
> What is still useful?
>
> The GPIO and Regulator drivers?
>
> > for the other functionality it provides.
> >
> > [1] https://github.com/beagleboard/beaglev-starlight
> >
> > Signed-off-by: Emil Renner Berthing <kernel@xxxxxxxx>
> > ---
> > .../devicetree/bindings/mfd/ti,tps65086.yaml | 3 ---
> > drivers/mfd/tps65086.c | 21 ++++++++++---------
> > 2 files changed, 11 insertions(+), 13 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/ti,tps65086.yaml b/Documentation/devicetree/bindings/mfd/ti,tps65086.yaml
> > index ba638bd10a58..4b629fcc0df9 100644
> > --- a/Documentation/devicetree/bindings/mfd/ti,tps65086.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/ti,tps65086.yaml
> > @@ -87,9 +87,6 @@ additionalProperties: false
> > required:
> > - compatible
> > - reg
> > - - interrupts
> > - - interrupt-controller
> > - - '#interrupt-cells'
>
> I can't say that I've been keeping up with the latest DT binding
> changes, but shouldn't these lines be relocated into some kind of
> optional listing?
>
> Or are optional properties omitted from documentation?
Optional properties are the ones not listed in the 'required' list.
Rob