Re: [PATCH Part2 RFC v4 02/40] KVM: SVM: Provide the Hypervisor Feature support VMGEXIT

From: Brijesh Singh
Date: Wed Jul 14 2021 - 17:00:42 EST




On 7/14/21 3:37 PM, Sean Christopherson wrote:
+#define SVM_VMGEXIT_HV_FT 0x8000fffd

This is fixing up commit 3 from Part1, though I think it can and should be
omitted from that patch entirely since it's not relevant to the guest, only to
KVM.

Yes, one of the thing which I was struggling header files between the kvm/queue and tip/master was not in sync. I had to do some cherry-picks to make my part2 still build. I hope this will get addressed in next rebase.


And FWIW, I like the verbose name, though it looks like Boris requested the
shorter names for the guest. Can we keep the verbose form for KVM-only VMEGXIT
name? Hyper-V has mostly laid claim to "HV", and feature is not the first thing
that comes to mind for "FT".


For the uapi/asm/svm.h, I can stick with the verbose name.

thanks