Re: [PATCH 2/3] spi: modify set_cs_timing parameter

From: Mark Brown
Date: Mon Aug 02 2021 - 16:16:31 EST


On Mon, Jul 19, 2021 at 05:16:43PM +0800, Mason Zhang wrote:
> From: Mason Zhang <Mason.Zhang@xxxxxxxxxxxx>
>
> No need pass in spi_delay to set_cs_timing callback.

This breaks the build:

/mnt/kernel/drivers/spi/spi-tegra114.c: In function 'tegra_spi_probe':
/mnt/kernel/drivers/spi/spi-tegra114.c:1328:24: error: assignment to 'int (*)(struct spi_device *)' from incompatible pointer type 'int (*)(struct spi_device *, struct spi_delay *, struct spi_delay *, struct spi_delay *)' [-Werror=incompatible-pointer-types]
master->set_cs_timing = tegra_spi_set_hw_cs_timing;
^

Attachment: signature.asc
Description: PGP signature