Re: [PATCH 2/3] spi: modify set_cs_timing parameter
From: Mason Zhang
Date: Mon Aug 02 2021 - 23:31:32 EST
On Mon, 2021-08-02 at 21:16 +0100, Mark Brown wrote:
> On Mon, Jul 19, 2021 at 05:16:43PM +0800, Mason Zhang wrote:
> > From: Mason Zhang <Mason.Zhang@xxxxxxxxxxxx>
> >
> > No need pass in spi_delay to set_cs_timing callback.
>
> This breaks the build:
>
> /mnt/kernel/drivers/spi/spi-tegra114.c: In function 'tegra_spi_probe':
> /mnt/kernel/drivers/spi/spi-tegra114.c:1328:24: error: assignment to 'int (*)(struct spi_device *)' from incompatible pointer type 'int (*)(struct spi_device *, struct spi_delay *, struct spi_delay *, struct spi_delay *)' [-Werror=incompatible-pointer-types]
> master->set_cs_timing = tegra_spi_set_hw_cs_timing;
> ^
Dear Mark:
I have fixed this build err in this patch:
https://lore.kernel.org/linux-spi/20210803021328.28291-1-Mason.Zhang@xxxxxxxxxxxx/T/#u
Thanks
Mason