Re: [PATCH v4 2/2] blk-zoned: allow BLKREPORTZONE without CAP_SYS_ADMIN

From: Johannes Thumshirn
Date: Mon Aug 09 2021 - 05:58:24 EST


On 09/08/2021 11:50, Niklas Cassel wrote:
> From: Niklas Cassel <niklas.cassel@xxxxxxx>
>
> A user space process should not need the CAP_SYS_ADMIN capability set
> in order to perform a BLKREPORTZONE ioctl.
>
> Getting the zone report is required in order to get the write pointer.
> Neither read() nor write() requires CAP_SYS_ADMIN, so it is reasonable
> that a user space process that can read/write from/to the device, also
> can get the write pointer. (Since e.g. writes have to be at the write
> pointer.)
>
> Fixes: 3ed05a987e0f ("blk-zoned: implement ioctls")
> Signed-off-by: Niklas Cassel <niklas.cassel@xxxxxxx>
> Reviewed-by: Damien Le Moal <damien.lemoal@xxxxxx>
Nit: Missing 'w'
> Reviewed-by: Aravind Ramesh <aravind.ramesh@xxxxxxx>
> Reviewed-by: Adam Manzanares <a.manzanares@xxxxxxxxxxx>
> Reviewed-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx # v4.10+
> ---
Looks good,
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@xxxxxxx>