Re: [PATCH v4 2/2] blk-zoned: allow BLKREPORTZONE without CAP_SYS_ADMIN

[Niklas Cassel]

On Mon, Aug 09, 2021 at 09:58:17AM +0000, Johannes Thumshirn wrote:
> On 09/08/2021 11:50, Niklas Cassel wrote:
> > From: Niklas Cassel <niklas.cassel@xxxxxxx>
> > 
> > A user space process should not need the CAP_SYS_ADMIN capability set
> > in order to perform a BLKREPORTZONE ioctl.
> > 
> > Getting the zone report is required in order to get the write pointer.
> > Neither read() nor write() requires CAP_SYS_ADMIN, so it is reasonable
> > that a user space process that can read/write from/to the device, also
> > can get the write pointer. (Since e.g. writes have to be at the write
> > pointer.)
> > 
> > Fixes: 3ed05a987e0f ("blk-zoned: implement ioctls")
> > Signed-off-by: Niklas Cassel <niklas.cassel@xxxxxxx>
> > Reviewed-by: Damien Le Moal <damien.lemoal@xxxxxx>
> Nit: Missing 'w'

Seems like Damien's email had a typo in his original reply:

https://patchwork.kernel.org/project/linux-block/patch/20210614122303.154378-3-Niklas.Cassel@xxxxxxx/#24252237

Surprised that he doesn't have a shortcut to paste his Reviewed-by tag,
considering the amount of patches that he reviews :)

> > Reviewed-by: Aravind Ramesh <aravind.ramesh@xxxxxxx>
> > Reviewed-by: Adam Manzanares <a.manzanares@xxxxxxxxxxx>
> > Reviewed-by: Himanshu Madhani <himanshu.madhani@xxxxxxxxxx>
> > Cc: stable@xxxxxxxxxxxxxxx # v4.10+
> > ---
> Looks good,
> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@xxxxxxx>
> 
>