Re: [PATCH 5.10 026/103] ice: do not abort devlink info if board identifier cant be found

[Pavel Machek]

Hi!

> From: Jacob Keller <jacob.e.keller@xxxxxxxxx>
> 
> [ Upstream commit a8f89fa27773a8c96fd09fb4e2f4892d794f21f6 ]
> 
> The devlink dev info command reports version information about the
> device and firmware running on the board. This includes the "board.id"
> field which is supposed to represent an identifier of the board design.
> The ice driver uses the Product Board Assembly identifier for this.
> 
> In some cases, the PBA is not present in the NVM. If this happens,
> devlink dev info will fail with an error. Instead, modify the
> ice_info_pba function to just exit without filling in the context
> buffer. This will cause the board.id field to be skipped. Log a dev_dbg
> message in case someone wants to confirm why board.id is not showing up
> for them.

Will it cause field to be skipped? I believe buffer will not be
initialized which will result in some confusion...

Best regards,
							Pavel

> +++ b/drivers/net/ethernet/intel/ice/ice_devlink.c
> @@ -23,7 +23,9 @@ static int ice_info_pba(struct ice_pf *pf, char *buf, size_t len)
>  
>  	status = ice_read_pba_string(hw, (u8 *)buf, len);
>  	if (status)
> -		return -EIO;
> +		/* We failed to locate the PBA, so just skip this entry */
> +		dev_dbg(ice_pf_to_dev(pf), "Failed to read Product Board Assembly string, status %s\n",
> +			ice_stat_str(status));
>  
>  	return 0;
>  }

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Attachment: signature.asc
Description: PGP signature