Re: [PATCH v3 1/3] kernel/resource: clean up and optimize iomem_is_exclusive()
From: Williams, Dan J
Date: Wed Sep 01 2021 - 15:43:29 EST
On Tue, 2021-08-31 at 22:21 +0200, David Hildenbrand wrote:
> We end up traversing subtrees of ranges we are not interested in; let's
> optimize this case, skipping such subtrees, cleaning up the function a bit.
> Signed-off-by: David Hildenbrand <david@xxxxxxxxxx>
> kernel/resource.c | 25 ++++++++++++++++++++-----
> 1 file changed, 20 insertions(+), 5 deletions(-)
That diffstat does not come across as "cleanup", and the skip_children
flag changing values mid-iteration feels tricky. Is there a win here,
the same number of entries still need to be accessed, right?
BTW, I had to pull this from lore to reply to it, looks like the
intended Cc's were missing?