RE: [PATCH 1/3] scsi: ufs: Probe for temperature notification support

[Avri Altman]

> 
> On 9/1/21 5:37 AM, Avri Altman wrote:
> > +static inline bool ufshcd_is_high_temp_notif_allowed(struct ufs_hba *hba)
> > +{
> > +     return hba->dev_info.high_temp_notif;
> > +}
> > +
> > +static inline bool ufshcd_is_low_temp_notif_allowed(struct ufs_hba *hba)
> > +{
> > +     return hba->dev_info.low_temp_notif;
> > +}
> 
> Please do not introduce single line inline functions.
Done.

> 
> > +static inline bool ufshcd_is_temp_notif_allowed(struct ufs_hba *hba)
> > +{
> > +     return ufshcd_is_high_temp_notif_allowed(hba) ||
> > +            ufshcd_is_high_temp_notif_allowed(hba);
> > +}
> 
> Since this function is not in any hot path (command processing),
> shouldn't it be moved into ufshcd.c?
Done.

> 
> Thanks,
> 
> Bart.