Re: [PATCH] KVM: Drop unused kvm_dirty_gfn_harvested()

[Vitaly Kuznetsov]

Peter Xu <peterx@xxxxxxxxxx> writes:

> Drop the unused function as reported by test bot.

Your subject line says "Drop unused kvm_dirty_gfn_harvested()" while in
reallity you drop "kvm_dirty_gfn_invalid()".

>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Signed-off-by: Peter Xu <peterx@xxxxxxxxxx>
> ---
>  virt/kvm/dirty_ring.c | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/virt/kvm/dirty_ring.c b/virt/kvm/dirty_ring.c
> index 7aafefc50aa7..88f4683198ea 100644
> --- a/virt/kvm/dirty_ring.c
> +++ b/virt/kvm/dirty_ring.c
> @@ -91,11 +91,6 @@ static inline void kvm_dirty_gfn_set_dirtied(struct kvm_dirty_gfn *gfn)
>  	gfn->flags = KVM_DIRTY_GFN_F_DIRTY;
>  }
>  
> -static inline bool kvm_dirty_gfn_invalid(struct kvm_dirty_gfn *gfn)
> -{
> -	return gfn->flags == 0;
> -}
> -
>  static inline bool kvm_dirty_gfn_harvested(struct kvm_dirty_gfn *gfn)
>  {
>  	return gfn->flags & KVM_DIRTY_GFN_F_RESET;

-- 
Vitaly