Re: [PATCH] KVM: Drop unused kvm_dirty_gfn_harvested()

From: Sean Christopherson
Date: Thu Sep 02 2021 - 12:40:34 EST


On Thu, Sep 02, 2021, Vitaly Kuznetsov wrote:
> Peter Xu <peterx@xxxxxxxxxx> writes:
>
> > Drop the unused function as reported by test bot.
>
> Your subject line says "Drop unused kvm_dirty_gfn_harvested()" while in
> reallity you drop "kvm_dirty_gfn_invalid()".

Heh, Peter already sent v2[*]. Though that's a good reminder that it's helpful
to reviewers to respond to your own patch if there's a fatal mistake and you're
going to immediately post a new version. For tiny patches it's not a big deal,
but for larger patches it can avoid wasting reviewers' time.

https://lkml.kernel.org/r/20210901230904.15164-1-peterx@xxxxxxxxxx