Re: [PATCH v2] nvme: avoid race in shutdown namespace removal

From: Christoph Hellwig
Date: Mon Sep 06 2021 - 04:03:41 EST


On Thu, Sep 02, 2021 at 11:20:02AM +0200, Daniel Wagner wrote:
> When we remove the siblings entry, we update ns->head->list, hence we
> can't separate the removal and test for being empty. They have to be
> in the same critical section to avoid a race.
>
> To avoid breaking the refcounting imbalance again, add a list empty
> check to nvme_find_ns_head.

Hannes, can you look over this and run your tests on it?