Re: [PATCH v1] media: atomisp: fix compilation error

[Dan Carpenter]

On Sun, Sep 05, 2021 at 12:12:21PM -0700, Tong Zhang wrote:
> I am getting the following compilation error on ubuntu 20.04 with gcc 9.3.0.
> 
> drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c: In function ‘input_system_configure_channel_sensor’:
> drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c:1649:1: error: control reaches end of non-void function [-Werror=return-type]
>  1649 | }
>       | ^
> cc1: some warnings being treated as errors
> make[4]: *** [scripts/Makefile.build:277: drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.o] Error 1
> 
> I made some minor changes to the switch-case to keep gcc happy.
> 
> Signed-off-by: Tong Zhang <ztong0001@xxxxxxxxx>

That's so weird.  This is the second patch for this I have seen today.
Meanwhile it was fix on Aug 2 with commit 05344a1d2ea7 ("media: atomisp:
restore missing 'return' statement").

Btw, in the future, this kind of patch needs a Fixes tag.

regards,
dan carpenter