[RFC PATCH 1/3] misc_cgroup: introduce misc.events and misc_events.local

From: brookxu
Date: Wed Sep 08 2021 - 01:24:56 EST


From: Chunguang Xu <brookxu@xxxxxxxxxxx>

Introduce misc.events and misc.events.local to make it easier for
us to understand the pressure of resources. The main idea comes
from mem_cgroup.

Signed-off-by: Chunguang Xu <brookxu@xxxxxxxxxxx>
---
include/linux/misc_cgroup.h | 9 +++++++
kernel/cgroup/misc.c | 50 ++++++++++++++++++++++++++++++++++++-
2 files changed, 58 insertions(+), 1 deletion(-)

diff --git a/include/linux/misc_cgroup.h b/include/linux/misc_cgroup.h
index da2367e2ac1e..d29f1743fae9 100644
--- a/include/linux/misc_cgroup.h
+++ b/include/linux/misc_cgroup.h
@@ -46,6 +46,15 @@ struct misc_res {
*/
struct misc_cg {
struct cgroup_subsys_state css;
+
+ /* misc.events */
+ atomic_long_t events[MISC_CG_RES_TYPES];
+ struct cgroup_file events_file;
+
+ /* misc.events.local */
+ atomic_long_t events_local[MISC_CG_RES_TYPES];
+ struct cgroup_file events_local_file;
+
struct misc_res res[MISC_CG_RES_TYPES];
};

diff --git a/kernel/cgroup/misc.c b/kernel/cgroup/misc.c
index ec02d963cad1..2a3d14be21e5 100644
--- a/kernel/cgroup/misc.c
+++ b/kernel/cgroup/misc.c
@@ -140,7 +140,7 @@ static void misc_cg_cancel_charge(enum misc_res_type type, struct misc_cg *cg,
int misc_cg_try_charge(enum misc_res_type type, struct misc_cg *cg,
unsigned long amount)
{
- struct misc_cg *i, *j;
+ struct misc_cg *i, *j, *k;
int ret;
struct misc_res *res;
int new_usage;
@@ -171,6 +171,16 @@ int misc_cg_try_charge(enum misc_res_type type, struct misc_cg *cg,
return 0;

err_charge:
+ if (cgroup_subsys_on_dfl(misc_cgrp_subsys)) {
+ atomic_long_inc(&i->events_local[type]);
+ cgroup_file_notify(&i->events_local_file);
+
+ for (k = i; k; k = parent_misc(k)) {
+ atomic_long_inc(&k->events[type]);
+ cgroup_file_notify(&k->events_file);
+ }
+ }
+
for (j = cg; j != i; j = parent_misc(j))
misc_cg_cancel_charge(type, j, amount);
misc_cg_cancel_charge(type, i, amount);
@@ -335,6 +345,32 @@ static int misc_cg_capacity_show(struct seq_file *sf, void *v)
return 0;
}

+static int misc_events_show(struct seq_file *sf, void *v)
+{
+ struct misc_cg *cg = css_misc(seq_css(sf));
+ unsigned long count, i;
+
+ for (i = 0; i < MISC_CG_RES_TYPES; i++) {
+ count = atomic_long_read(&cg->events[i]);
+ if (READ_ONCE(misc_res_capacity[i]) || count)
+ seq_printf(sf, "%s %lu\n", misc_res_name[i], count);
+ }
+ return 0;
+}
+
+static int misc_events_local_show(struct seq_file *sf, void *v)
+{
+ struct misc_cg *cg = css_misc(seq_css(sf));
+ unsigned long count, i;
+
+ for (i = 0; i < MISC_CG_RES_TYPES; i++) {
+ count = atomic_long_read(&cg->events_local[i]);
+ if (READ_ONCE(misc_res_capacity[i]) || count)
+ seq_printf(sf, "%s %lu\n", misc_res_name[i], count);
+ }
+ return 0;
+}
+
/* Misc cgroup interface files */
static struct cftype misc_cg_files[] = {
{
@@ -353,6 +389,18 @@ static struct cftype misc_cg_files[] = {
.seq_show = misc_cg_capacity_show,
.flags = CFTYPE_ONLY_ON_ROOT,
},
+ {
+ .name = "events",
+ .flags = CFTYPE_NOT_ON_ROOT,
+ .file_offset = offsetof(struct misc_cg, events_file),
+ .seq_show = misc_events_show,
+ },
+ {
+ .name = "events.local",
+ .flags = CFTYPE_NOT_ON_ROOT,
+ .file_offset = offsetof(struct misc_cg, events_local_file),
+ .seq_show = misc_events_local_show,
+ },
{}
};

--
2.30.0