Re: [PATCH 11/12] xen/pci-swiotlb: reduce visibility of symbols

From: Christoph Hellwig
Date: Wed Sep 08 2021 - 03:10:21 EST


On Tue, Sep 07, 2021 at 02:11:14PM +0200, Jan Beulich wrote:
> xen_swiotlb and pci_xen_swiotlb_init() are only used within the file
> defining them, so make them static and remove the stubs. Otoh
> pci_xen_swiotlb_detect() has a use (as function pointer) from the main
> pci-swiotlb.c file - convert its stub to a #define to NULL.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>