Re: [PATCH 3/3] arm64: dts: qcom: pm8350c: Add pwm support

[skakit]

On 2021-09-07 23:46, Matthias Kaehlcke wrote:
> On Mon, Sep 06, 2021 at 04:11:07PM +0530, satya priya wrote:
> > Add pwm support for PM8350C pmic.
> >
> > Signed-off-by: satya priya <skakit@xxxxxxxxxxxxxx>
> > ---
> >  arch/arm64/boot/dts/qcom/pm8350c.dtsi | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/pm8350c.dtsi 
> > b/arch/arm64/boot/dts/qcom/pm8350c.dtsi
> > index e1b75ae..ecdae55 100644
> > --- a/arch/arm64/boot/dts/qcom/pm8350c.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/pm8350c.dtsi
> > @@ -29,6 +29,12 @@
> >  			interrupt-controller;
> >  			#interrupt-cells = <2>;
> >  		};
> > +
> > +		pm8350c_pwm4: pwm {
>
> What does the '4' represent, an internal channel number? It should
> probably be omitted if the PM8350 only has a single output PWM
> port.

pm8350c has four PWMs, but I think we can drop the '4' here.

> > +			compatible = "qcom,pm8350c-pwm";
> > +			#pwm-cells = <2>;
> > +			status = "okay";
>
> I don't think it should be enabled by default, there may be boards with
> the PM8350C that don't use the PWM.

Okay.