Re: [PATCH -next] dmaengine: idxd: Use list_move_tail instead of list_del/list_add_tail

From: Dave Jiang
Date: Wed Sep 08 2021 - 12:43:20 EST



On 9/8/2021 2:28 AM, Bixuan Cui wrote:
Using list_move_tail() instead of list_del() + list_add_tail()

Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
Signed-off-by: Bixuan Cui <cuibixuan@xxxxxxxxxx>

Thanks!

Acked-by: Dave Jiang <dave.jiang@xxxxxxxxx>


---
drivers/dma/idxd/irq.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/dma/idxd/irq.c b/drivers/dma/idxd/irq.c
index ca88fa7a328e..79fcfc4883e4 100644
--- a/drivers/dma/idxd/irq.c
+++ b/drivers/dma/idxd/irq.c
@@ -221,8 +221,7 @@ static void irq_process_work_list(struct idxd_irq_entry *irq_entry)
list_for_each_entry_safe(desc, n, &irq_entry->work_list, list) {
if (desc->completion->status) {
- list_del(&desc->list);
- list_add_tail(&desc->list, &flist);
+ list_move_tail(&desc->list, &flist);
}
}