Re: [for-next][PATCH 08/12] bootconfig: Fix missing return check of xbc_node_compose_key function

[Steven Rostedt]

On Wed, 08 Sep 2021 15:18:59 -0400
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> From: Julio Faracco <jcfaracco@xxxxxxxxx>
> 
> The function `xbc_show_list should` handle the keys during the
> composition. Even the errors returned by the compose function. Instead
> of removing the `ret` variable, it should save the value and show the
> exact error. This missing variable is causing a compilation issue also.
> 
> Link: https://lkml.kernel.org/r/163077087861.222577.12884543474750968146.stgit@devnote2
> 
> Fixes: e5efaeb8a8f5 ("bootconfig: Support mixing a value and subkeys under a key")
> Signed-off-by: Julio Faracco <jcfaracco@xxxxxxxxx>
> Acked-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>

> Cc: stable@xxxxxxxxxxxxxxx

Oops, a typo. That should be: stable@xxxxxxxxxxxxxxx or
stable@xxxxxxxxxx. There is no "vgar" ;-)

I'll fix this up.

-- Steve


> Signed-off-by: Steven Rostedt (VMware) <rostedt@xxxxxxxxxxx>