Re: [PATCH 3/7] arm64: dts: qcom: msm8998-xperia: Add support for wcn3990 Bluetooth

[AngeloGioacchino Del Regno]

Il 09/09/21 15:19, Dmitry Baryshkov ha scritto:
> On 03/09/2021 21:09, AngeloGioacchino Del Regno wrote:
> > This platform uses the WCN3990 Bluetooth chip, reachable on UART-3.
> >
> > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxxx>
> > Reviewed-by: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx>
> > ---
> >   .../dts/qcom/msm8998-sony-xperia-yoshino.dtsi   | 17 +++++++++++++++++
> >   1 file changed, 17 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/msm8998-sony-xperia-yoshino.dtsi 
> > b/arch/arm64/boot/dts/qcom/msm8998-sony-xperia-yoshino.dtsi
> > index 2fe53e4675d5..66b009ba72fe 100644
> > --- a/arch/arm64/boot/dts/qcom/msm8998-sony-xperia-yoshino.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/msm8998-sony-xperia-yoshino.dtsi
> > @@ -179,6 +179,23 @@ &blsp1_i2c5_sleep {
> >       bias-disable;
> >   };
> > +&blsp1_uart3 {
> > +    status = "okay";
> > +
> > +    bluetooth {
> > +        compatible = "qcom,wcn3990-bt";
> > +
> > +        vddio-supply = <&vreg_s4a_1p8>;
> > +        vddxo-supply = <&vreg_l7a_1p8>;
> > +        vddrf-supply = <&vreg_l17a_1p3>;
> > +        vddch0-supply = <&vreg_l25a_3p3>;
> > +        max-speed = <3200000>;
> > +
> > +        clocks = <&rpmcc RPM_SMD_RF_CLK2_PIN>;
> > +    };
> > +};
>
> There is an ongoing proposal to rework wcn3990 (bt and wifi) bindings, so we might 
> want to delay this a bit. Not a strict requirement, since the changes would be 
> backwards-compatible.

Delaying this patch is not a problem on my side - but if the changes are backwards
compatible, do we really have reasons to delay it?

In any case, I trust your judgement on this: if you want to delay it, I will send
the wcn3990 support after the rework.

Cheers,
- Angelo