Re: [PATCH v2] perf list: Display hybrid pmu events with cpu type

From: Jin, Yao
Date: Thu Sep 09 2021 - 21:06:15 EST




On 9/10/2021 6:56 AM, Andi Kleen wrote:

On 9/9/2021 3:37 PM, Ian Rogers wrote:
On Thu, Sep 2, 2021 at 7:54 PM Jin Yao <yao.jin@xxxxxxxxxxxxxxx> wrote:
Add a new option '--cputype' to perf-list to display core-only pmu events
or atom-only pmu events.

Each hybrid pmu event has been assigned with a pmu name, this patch
compares the pmu name before listing the result.
Would this work more broadly for any PMU type? If so perhaps pmu
rather than cputype is a more appropriate option name?

It's not just the cpu pmu, because it still lists the uncore events, which makes sense.

If you want to match the pmu it probably would make sense to match it in the default matching for non option arguments in perf list. But that would be a different patch.

-Andi



Yes, agree with Andi. Besides for cpu pmu events, it also lists the software events and uncore events. So probably cputype is an appropriate option name.

Thanks
Jin Yao