Re: [PATCH] staging: rtl8723bs: remove unused macros from ioctl_linux.c

From: Hans de Goede
Date: Fri Sep 10 2021 - 02:24:38 EST


Hi,

On 9/9/21 11:19 PM, Michael Straube wrote:
> These macros are not used in the driver, remove them.
> Found with GCC -Wunused-macros.
>
> Signed-off-by: Michael Straube <straube.linux@xxxxxxxxx>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>

Regards,

Hans


> ---
> drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 14 --------------
> 1 file changed, 14 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> index 908022a17b3f..27fb1be036b8 100644
> --- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> @@ -15,20 +15,6 @@
>
> #define RTL_IOCTL_WPA_SUPPLICANT (SIOCIWFIRSTPRIV+30)
>
> -#define SCAN_ITEM_SIZE 768
> -#define MAX_CUSTOM_LEN 64
> -#define RATE_COUNT 4
> -
> -/* combo scan */
> -#define WEXT_CSCAN_HEADER "CSCAN S\x01\x00\x00S\x00"
> -#define WEXT_CSCAN_HEADER_SIZE 12
> -#define WEXT_CSCAN_SSID_SECTION 'S'
> -#define WEXT_CSCAN_CHANNEL_SECTION 'C'
> -#define WEXT_CSCAN_ACTV_DWELL_SECTION 'A'
> -#define WEXT_CSCAN_PASV_DWELL_SECTION 'P'
> -#define WEXT_CSCAN_HOME_DWELL_SECTION 'H'
> -#define WEXT_CSCAN_TYPE_SECTION 'T'
> -
> static int wpa_set_auth_algs(struct net_device *dev, u32 value)
> {
> struct adapter *padapter = rtw_netdev_priv(dev);
>