Re: [PATCH 1/3] x86/amd_nb: Add support for HSMP mailbox access

[Borislav Petkov]

On Wed, Sep 08, 2021 at 10:41:20PM +0530, Chatradhi, Naveen Krishna wrote:
> In all the future server platforms, AMD's direction is the support HSMP
> interface, which exposes system management knobs.

I know you all think about the future only but there's the past too and
there's a bunch of AMD hardware out there which doesn't have that.

> > You could make it a separate driver module called amd_hsmp.ko which
> > loads only on the appropriate hw and uses amd_nb.c for detection only
> > like the other drivers, for example.
> 
> How about, creating a module under drivers/platform/x86/ (lets say
> amd_hsmp.c) export an API from here and it can be extended to support all
> the knobs that does not fit in an existing frameworks (such as hwmon, etc)
> and provide a user space access.
> 
> I can see similar references in the drivers/platform/x86/ directory.

That sounds ok to me too. There's also arch/x86/platform/, btw, and I
still have to find out what the difference is. :-)

Lemme add the platform drivers folks.

Thread begins at:

https://lkml.kernel.org/r/20210902174155.7365-1-nchatrad@xxxxxxx

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette