Re: [PATCH 4/8] dt-bindings: clock: arm,syscon-icst: Use 'reg' instead of 'vco-offset' for VCO register address

From: Rob Herring
Date: Fri Sep 10 2021 - 09:12:11 EST


On Thu, Sep 9, 2021 at 4:31 PM Rob Herring <robh@xxxxxxxxxx> wrote:
>
> 'reg' is the standard property for defining register banks/addresses. Add
> it to use for the VCO register address and deprecate 'vco-offset'. This
> will also allow for using standard node names with unit-addresses.
>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Cc: Stephen Boyd <sboyd@xxxxxxxxxx>
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Cc: linux-clk@xxxxxxxxxxxxxxx
> Cc: Michael Turquette <mturquette@xxxxxxxxxxxx>
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml b/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> index 118c5543e037..c346287ca15d 100644
> --- a/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> +++ b/Documentation/devicetree/bindings/clock/arm,syscon-icst.yaml
> @@ -69,6 +69,10 @@ properties:
> - arm,impd1-vco1
> - arm,impd1-vco2
>
> + reg:
> + maxItems: 1
> + description: The VCO register
> +
> clocks:
> description: Parent clock for the ICST VCO
> maxItems: 1
> @@ -83,6 +87,7 @@ properties:
> vco-offset:
> $ref: '/schemas/types.yaml#/definitions/uint32'
> description: Offset to the VCO register for the oscillator
> + deprecated

Sigh, that should be 'deprecated: true'.

Rob