Re: [PATCH] of: property: Disable fw_devlink DT support for X86

From: Rob Herring
Date: Fri Sep 10 2021 - 12:14:57 EST


On Thu, 09 Sep 2021 18:14:45 -0700, Saravana Kannan wrote:
> Andre reported fw_devlink=on breaking OLPC XO-1.5 [1].
>
> OLPC XO-1.5 is an X86 system that uses a mix of ACPI and OF to populate
> devices. The root cause seems to be ISA devices not setting their fwnode
> field. But trying to figure out how to fix that doesn't seem worth the
> trouble because the OLPC devicetree is very sparse/limited and fw_devlink
> only adds the links causing this issue. Considering that there aren't many
> users of OF in an X86 system, simply fw_devlink DT support for X86.
>
> [1] - https://lore.kernel.org/lkml/3c1f2473-92ad-bfc4-258e-a5a08ad73dd0@xxxxxx/
> Fixes: ea718c699055 ("Revert "Revert "driver core: Set fw_devlink=on by default""")
> Signed-off-by: Saravana Kannan <saravanak@xxxxxxxxxx>
> Cc: Andre Muller <andre.muller@xxxxxx>
> ---
> drivers/of/property.c | 3 +++
> 1 file changed, 3 insertions(+)
>

Applied, thanks!