Re: [PATCH v2 06/15] leds: trigger: blkdev: Add function to get gendisk by name

[Ian Pilcher]

On 9/10/21 1:45 AM, Greg KH wrote:
> On Thu, Sep 09, 2021 at 05:25:04PM -0500, Ian Pilcher wrote:
> > +/* Must be built-in to access block_class */
> > +struct gendisk *ledtrig_blkdev_get_disk(const char *const name)
> > +{
> > +	struct device *dev;
> > +
> > +	dev = class_find_device(&block_class, NULL, name, blkdev_match_name);
> > +	if (dev == NULL)
> > +		return NULL;
>
> You now have bumped the reference count on this structure.  Where do you
> decrement it when you are finished with it?

With context this time.  Sorry about that.


That happens when I "unlink" the block device from the LED in
blkdev_disk_unlink_locked() at ledtrig-blkdev.c:410.

(And also in the error path of link_device_store() at
ledtrig-blkdev.c:372.)

--
========================================================================
                 In Soviet Russia, Google searches you!
========================================================================