Re: [PATCH 0/7] remove pointers from struct hal_ops

[Michael Straube]

On 9/11/21 11:38, Fabio M. De Francesco wrote:
> On Friday, September 10, 2021 10:50:26 PM CEST Michael Straube wrote:
> > This series removes some more pointers from struct hal_ops and
> > removes the function rtl8188e_set_hal_ops() that is empty after
> > the removals.
> >
> > Michael Straube (7):
> >    staging: r8188eu: remove mgnt_xmit from struct hal_ops
> >    staging: r8188eu: remove hal_xmit from struct hal_ops
> >    staging: r8188eu: remove read_bbreg from struct hal_ops
> >    staging: r8188eu: remove write_bbreg from struct hal_ops
> >    staging: r8188eu: remove read_rfreg from struct hal_ops
> >    staging: r8188eu: remove write_rfreg from struct hal_ops
> >    staging: r8188eu: remove rtl8188e_set_hal_ops()
>
> Hi Michael,
>
> This series is good.
>
> Furthermore, I compiled the whole series with gcc version 11.2.1 2020816
> [revision 056e324ce46a7924b5cf10f61010cf9dd2ca10e9] (SUSE Linux) one
> patch at a time. There are no errors or warnings at any time in any of the
> seven builds.
>
> But, unfortunately, I have no time to test. So the whole series is...
>
> Acked-by: Fabio M. De Francesco <fmdefrancesco@xxxxxxxxx>
>
> Thanks,
>
> Fabio

Hi Fabio,

thank you for the review. I have tested it on x86_64 with
Inter-Tech DMG-02 connected to a CCMP network without any
issues.

Perhaps I should have mentioned that in the cover letter. ;)

Thanks,

Michael