Re: [PATCH v3] drivers/cdrom: improved ioctl for media change detection
From: Lukas Prediger
Date: Sat Sep 11 2021 - 13:49:42 EST
Hi Randy, Hi Phil,
>>
>> Hi Lukas,
>>
>> Just a minor nit:
>>
>> On 9/10/21 2:16 PM, Lukas Prediger wrote:
>> > +#define MEDIA_CHANGED_FLAG 0x1 /* Last detected media change was more \
>> > + * recent than last_media_change set by\
>> > + * caller. \
>> > + */
>>
>> Drop the "continuation" backslashes.
>> They are not needed.
>>
>> thanks.
>> --
>> ~Randy
>>
Hm, my IDE was complaining about these but I just tested building without and
that worked fine. No idea what that was about then..
>
> Dear Lukas,
>
> Happy to take these out for you and save you resubmitting.
> I'm very happy with patch anyway. Once I hear back from
> you I'll send onto Jens with my approval after one final test :-)
>
That would be very nice of you!
>
> Thanks again for the code.
>
My pleasure, and thanks for the helpful feedback!
>
> Regards,
> Phil
Best regards,
Lukas