Re: [PATCH] perf tools: Fix perf_event_attr__fprintf() missing/dupl. fields

From: Arnaldo Carvalho de Melo
Date: Sat Sep 11 2021 - 14:58:57 EST


Em Sat, Sep 11, 2021 at 03:05:50PM +0300, Adrian Hunter escreveu:
> Some fields are missing and text_poke is duplicated. Fix that up.

Thanks, applied.

- Arnaldo


> Signed-off-by: Adrian Hunter <adrian.hunter@xxxxxxxxx>
> ---
> tools/perf/util/perf_event_attr_fprintf.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/perf_event_attr_fprintf.c b/tools/perf/util/perf_event_attr_fprintf.c
> index 30481825515b..47b7531f51da 100644
> --- a/tools/perf/util/perf_event_attr_fprintf.c
> +++ b/tools/perf/util/perf_event_attr_fprintf.c
> @@ -137,6 +137,9 @@ int perf_event_attr__fprintf(FILE *fp, struct perf_event_attr *attr,
> PRINT_ATTRf(cgroup, p_unsigned);
> PRINT_ATTRf(text_poke, p_unsigned);
> PRINT_ATTRf(build_id, p_unsigned);
> + PRINT_ATTRf(inherit_thread, p_unsigned);
> + PRINT_ATTRf(remove_on_exec, p_unsigned);
> + PRINT_ATTRf(sigtrap, p_unsigned);
>
> PRINT_ATTRn("{ wakeup_events, wakeup_watermark }", wakeup_events, p_unsigned);
> PRINT_ATTRf(bp_type, p_unsigned);
> @@ -150,7 +153,7 @@ int perf_event_attr__fprintf(FILE *fp, struct perf_event_attr *attr,
> PRINT_ATTRf(aux_watermark, p_unsigned);
> PRINT_ATTRf(sample_max_stack, p_unsigned);
> PRINT_ATTRf(aux_sample_size, p_unsigned);
> - PRINT_ATTRf(text_poke, p_unsigned);
> + PRINT_ATTRf(sig_data, p_unsigned);
>
> return ret;
> }
> --
> 2.17.1

--

- Arnaldo